Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolchains resolver plugin. #822

Merged

Conversation

halxinate
Copy link
Contributor

Fix #817 by adding opensource toolcahins resolver plugin to help simplify the local project configuration set up.

Fixes #817

  • Tested on a clean build with the fresh installation of Android Studio Ladybug | 2024.2.1 Patch 3. The issue is not manifesting.

Fix openwallet-foundation-labs#817 by adding opensource toolcahins resolver plugin to help simplify the local project configuration set up.

Signed-off-by: halxinate <[email protected]>
Copy link
Contributor

@davidz25 davidz25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, I ran into a similar problem a couple of weeks ago and this fixed it (later, the problem went away so I never sent it upstream).

@davidz25 davidz25 merged commit 5ae655b into openwallet-foundation-labs:main Dec 18, 2024
3 checks passed
@halxinate
Copy link
Contributor Author

halxinate commented Dec 19, 2024

Oh, I see what happened. I've added it in a rush for Kevin's review again, thinking I haven't requested it yet as I had problems re-testing it due to the gradle syncing caused by that "shallow clone fork" issue. And also not seeing the change in the diff as I forgot that I must sync the fork with the main repo explicitly first to see the change. As this was actually another, new fork.
Thank you for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't Sync project with gradle using fresh install of AS Ladybug.
2 participants